-
Notifications
You must be signed in to change notification settings - Fork 72
[ENG-8223] Fix mfr unittests #384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
felliott
merged 15 commits into
CenterForOpenScience:feature/buff-worms
from
mkovalua:fix-mfr-unittests
Jul 7, 2025
Merged
[ENG-8223] Fix mfr unittests #384
felliott
merged 15 commits into
CenterForOpenScience:feature/buff-worms
from
mkovalua:fix-mfr-unittests
Jul 7, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Here is an updated branch with all of the recent MFR dep-group updates: https://github.com/CenterForOpenScience/modular-file-renderer/tree/feature/fix-mfr-tests |
* fix error "jinja2.exceptions.TemplateNotFound: basic"; template_file looks to be deprecated and should be replaced with template_name
* fix errors: "EscapeHtml.extendMarkdown() missing 1 required positional argument: 'md_globals'" and "TypeError: 'Registry' object does not support item deletion". The markdown module now has explicit `deregister` methods for turning off certain render types
* `numpy.asscalar()` is now removed. Scalar context can be invoked by calling `.item()` on the object.
* resolve error: "RuntimeError: There is no current event loop in thread 'MainThread'." by removing deprecated get_new_ioloop
* Add dependency on openpyxl and rewrite xlsx-from-xlrd code to use it.
* Running `setup.py develop` is deprecated and should be replaced with `pip install .`. See [1]. [1] https://packaging.python.org/en/latest/guides/modernize-setup-py-project/
16871ee
to
7406f82
Compare
7ca4004
into
CenterForOpenScience:feature/buff-worms
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/ENG-8223
Purpose
MFR has a bunch of failing tests. Let's fix 'em!
If the cause of a test failure turns out to need a big fix, we can create another ticket to track it.
Changes
run pytest to check whether MFR testing is working and update code to be it competable with python3.13
created from the following PR
#381
to keep its changings
Side effects
QA Notes
Deployment Notes