Skip to content

[ENG-8223] Fix mfr unittests #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mkovalua
Copy link

Ticket

https://openscience.atlassian.net/browse/ENG-8223

Purpose

MFR has a bunch of failing tests. Let's fix 'em!
If the cause of a test failure turns out to need a big fix, we can create another ticket to track it.

Changes

run pytest to check whether MFR testing is working and update code to be it competable with python3.13

created from the following PR
#381
to keep its changings

Side effects

QA Notes

Deployment Notes

@felliott
Copy link
Member

Here is an updated branch with all of the recent MFR dep-group updates: https://github.com/CenterForOpenScience/modular-file-renderer/tree/feature/fix-mfr-tests

@mkovalua mkovalua marked this pull request as ready for review June 18, 2025 13:15
mkovalua and others added 15 commits July 7, 2025 11:00
 * fix error "jinja2.exceptions.TemplateNotFound: basic";
   template_file looks to be deprecated and should be replaced with
   template_name
 * fix errors: "EscapeHtml.extendMarkdown() missing 1 required
   positional argument: 'md_globals'" and "TypeError: 'Registry'
   object does not support item deletion". The markdown module now has
   explicit `deregister` methods for turning off certain render types
 * `numpy.asscalar()` is now removed. Scalar context can be invoked by
   calling `.item()` on the object.
 * resolve error: "RuntimeError: There is no current event loop in
   thread 'MainThread'." by removing deprecated get_new_ioloop
 * Add dependency on openpyxl and rewrite xlsx-from-xlrd code to use
   it.
 * Running `setup.py develop` is deprecated and should be replaced
   with `pip install .`. See [1].

 [1] https://packaging.python.org/en/latest/guides/modernize-setup-py-project/
@felliott felliott force-pushed the fix-mfr-unittests branch from 16871ee to 7406f82 Compare July 7, 2025 20:57
@felliott felliott merged commit 7ca4004 into CenterForOpenScience:feature/buff-worms Jul 7, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants